fix(release): separate docs search index generation #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-charts-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-angular ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-charts-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fix(release): cleanup chore(deps): bump fix(release): step chore(dco): bump action version chore(deps): bump chore(deps): bump vue chore(deps): bump chore(deps): bump dependencies
nstuyvesant
force-pushed
the
separate-docs-search-index
branch
from
52d0863
to
c67d700
Compare
nstuyvesant
commented
Sep 7, 2024
Comment on lines
+28
to
+32
| node-version: '20.x' | ||
| cache: 'yarn' | ||
| registry-url: 'https://registry.npmjs.org/' | ||
| always-auth: true | ||
| auth-token: ${{ secrets.NPM_TOKEN }} |
There was a problem hiding this comment.
Eliminate need for explicit minor versions, set yarn cache and npmjs authentication here instead of below.
nstuyvesant
commented
Sep 7, 2024
Comment on lines
+20
to
+23
| - name: Set git user to carbon-bot | ||
| run: | | ||
| git config --global user.email "carbon@us.ibm.com" | ||
| git config --global user.name "carbon-bot" |
There was a problem hiding this comment.
Moved these up closer to the checkout.
nstuyvesant
commented
Sep 7, 2024
Comment on lines
+37
to
+38
| - name: Generate search index for docs website | ||
| run: lerna run build:search --scope @carbon/charts-docs # should be committed in next step |
There was a problem hiding this comment.
Separated this from docs package build.
nstuyvesant
commented
Sep 7, 2024
|
|
||
| - name: Create version and change logs | ||
| - name: Create version and change logs and commit to master |
There was a problem hiding this comment.
As this commits the new version numbers to master, it can also commit the rebuilt search index for the docs website.
nstuyvesant
commented
Sep 7, 2024
Comment on lines
-43
to
-56
| - name: Commit and push changes (if there are any) | ||
| run: | | ||
| git add . | ||
| if ! git diff-index --quiet HEAD; then | ||
| git commit -m "skip-release - chore(build): updated search index for docs" | ||
| git push origin master | ||
| fi | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GH_TOKEN }} | ||
|
|
||
| - name: Publish to npmjs registry and Github | ||
| run: | | ||
| npm config set //registry.npmjs.org/:_authToken=${{ secrets.NPM_TOKEN }} -q | ||
| npx lerna publish from-git --yes --force-publish |
There was a problem hiding this comment.
Already handled above.
nstuyvesant
commented
Sep 7, 2024
Comment on lines
-16
to
+17
| "build": "yarn build:search && yarn build:docs && yarn files:pages && yarn build:api:docs", | ||
| "dev": "vite --port 3000", | ||
| "build": "yarn build:docs && yarn files:pages && yarn build:api:docs", | ||
| "dev": "yarn build:search && vite --port 3000", |
There was a problem hiding this comment.
Removed building of search index from docs package build. Ensure index is rebuilt before previewing site.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates